Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note for Hermes bundle manually #5231

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Add note for Hermes bundle manually #5231

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f19836d
Add note for Hermes bundle manually
marandaneto Jun 29, 2022
0c56bfa
Update src/platforms/react-native/manual-setup/hermes.mdx
marandaneto Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/platforms/react-native/manual-setup/hermes.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ If you are manually bundling and building React Native apps, follow this three-s

### Compile Sourcemaps

<Note>

We're currently facing issues when bundling the `hermes` bundle and `source maps` manually.
We'd recommend not bundling it manually for now till this issue gets fixed.
Follow the [issue[(https://github.com/facebook/react-native/issues/34043) for more details.
marandaneto marked this conversation as resolved.
Show resolved Hide resolved

</Note>

1. Bundle/minify with `metro` (`react-native`) to get the bundle (`.bundle`) and packager source map (`.packager.map`):

```bash {tabTitle:Android}
Expand Down