Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flutter profiling docs #8363

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 30, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Adds relevant docs for the Flutter profiling alpha.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

@vercel
Copy link

vercel bot commented Oct 30, 2023

@vaind is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 5:56pm

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me! Just added one line to your comment to explain a little more clearly, like we do with Python

src/platforms/common/profiling/index.mdx Outdated Show resolved Hide resolved
@vaind
Copy link
Collaborator Author

vaind commented Nov 1, 2023

@shanamatthews I've accepted the suggestion but cannot merge the PR.

@shanamatthews
Copy link
Contributor

Great. I believe this needs to wait for merge until there's a new flutter release, but I'll merge after that happens. @bruno-garcia is that right?

@vaind
Copy link
Collaborator Author

vaind commented Nov 1, 2023

Great. I believe this needs to wait for merge until there's a new flutter release, but I'll merge after that happens. @bruno-garcia is that right?

In that case: it's already released https://github.com/getsentry/sentry-dart/releases/tag/7.12.0

@shanamatthews
Copy link
Contributor

Oh perfect! I'll merge now @vaind

@shanamatthews shanamatthews merged commit 177e850 into getsentry:master Nov 1, 2023
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants