feat: packaging native runtime libs #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
force-pushed
the
chore/native-packaging
branch
8 times, most recently
from
4566b33
to
f42c5a6
Compare
vaind
changed the title
|
bruno-garcia
reviewed
Nov 3, 2023
vaind
force-pushed
the
chore/native-packaging
branch
2 times, most recently
from
19f4bd9
to
7b4195f
Compare
vaind
force-pushed
the
chore/native-packaging
branch
from
422e8d8
to
8856880
Compare
vaind
force-pushed
the
chore/native-packaging
branch
from
53282a8
to
9ff35c1
Compare
bruno-garcia
approved these changes
Nov 8, 2023
|
|
||
| Describe 'Console apps (<framework>) - native AOT publish' -ForEach @( | ||
| @{ framework = "net7.0" }, | ||
| @{ framework = "net8.0" } |
There was a problem hiding this comment.
Adding a new framework will be done here?
Could you please write some doc/instruction on how this works/how to keep it maintained or add new frameworks?
There was a problem hiding this comment.
I've written some intro in CONTRIBUTING.md (https://github.com/getsentry/sentry-dotnet/pull/2781/files#diff-eca12c0a30e25b4b46522ebf89465a03ba72a03f540796c979137931d8f92055R138).
And you've guessed right so the question of adding frameworks should be clear then :)
But if you have questions that you don't know the answer to (or anyone else does), feel free to post here and I'll update the docs.
This was referenced Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2247 and #2772
Besides packaging sentry-native static lib properly, this adds integration testing capabilities where now we create sample apps with
dotnet newand test against actual nuget packages, instead of relying on all those build props/targets that are implied on Sample projects inside our repo.Followup: #2809 - MAUI test is currently disabled to unblock this PR
#skip-changelog - there will be a single item for Native AOT support