-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DisabledHub.StartTransaction now returns NoOpTransaction #3581
Conversation
macOS is not happy today |
Yeah I'm not even seeing any errors in the logs. It runs
That leaves us in a bit of a pickle... unless we want to host our own runners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can we expand on this and use the NoOpTransaction based on a sampling rate at the start of a transaction and not the end? |
That's a very fair request that I put in #3636. We're moving towards something of a spans-only world but maybe we can sneak this in somewhere in between to make life easier? |
Resolves #829
Replaces #3574 (cherry picked commits to target
main
branch instead of theversion-5.0.0
branch.