Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope.Transaction is now AsyncLocal #3596

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Scope.Transaction is now AsyncLocal #3596

merged 5 commits into from
Sep 17, 2024

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Sep 5, 2024 •
edited
Loading

@jamescrosswell jamescrosswell linked an issue Sep 5, 2024 that may be closed by this pull request
SentryScope.Transaction should always be AsyncLocal #3590
Open
@jamescrosswell jamescrosswell marked this pull request as ready for review September 11, 2024 02:18
bruno-garcia
bruno-garcia approved these changes Sep 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/Sentry/Scope.cs Show resolved Hide resolved
src/Sentry/Scope.cs Outdated Show resolved Hide resolved
@jamescrosswell jamescrosswell merged commit 9f0e0ff into version-5.0.0 Sep 17, 2024
20 checks passed
@jamescrosswell jamescrosswell deleted the scope-transaction-async-local branch September 17, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SentryScope.Transaction should always be AsyncLocal
2 participants
@jamescrosswell @bruno-garcia