Skip to content

Commit

Permalink
ci: Add Go 1.20 and remove Go 1.17 (#563)
Browse files Browse the repository at this point in the history
Co-authored-by: Anton Ovchinnikov <[email protected]>
  • Loading branch information
cleptric and tonyo authored Feb 17, 2023
1 parent 297d2c2 commit 0a44c63
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 18 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.19"
go-version: "1.20"
- uses: actions/checkout@v3
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.50
version: v1.51
only-new-issues: true
timeout-minutes: 10
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
run: make vet
- name: Check go.mod Tidiness
run: make mod-tidy
if: ${{ matrix.go == '1.19' }}
if: ${{ matrix.go == '1.20' }}
- name: Test
run: make test
- name: Test (with race detection)
Expand All @@ -56,7 +56,7 @@ jobs:
# pull requests, only run this step for a single job in the matrix. For
# all other workflow triggers (e.g., pushes to a release branch) run
# this step for the whole matrix.
if: ${{ github.event_name != 'pull_request' || (matrix.go == '1.19' && matrix.os == 'ubuntu') }}
if: ${{ github.event_name != 'pull_request' || (matrix.go == '1.20' && matrix.os == 'ubuntu') }}
- name: Collect coverage
run: make test-coverage
- name: Upload coverage to Codecov
Expand All @@ -66,7 +66,7 @@ jobs:
timeout-minutes: 10
strategy:
matrix:
go: ["1.19", "1.18", "1.17"]
go: ["1.20", "1.19", "1.18"]
os: [ubuntu, windows, macos]
fail-fast: false
# Test the GOPATH mode with the oldest Go version we support
Expand All @@ -86,7 +86,7 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: "1.17"
go-version: "1.18"
- uses: actions/checkout@v3
with:
path: ${{ env.WORKDIR }}
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ mod-tidy: ## Check go.mod tidiness
for dir in $(ALL_GO_MOD_DIRS); do \
cd "$${dir}"; \
echo ">>> Running 'go mod tidy' for module: $${dir}"; \
go mod tidy -go=1.19 -compat=1.17; \
go mod tidy -go=1.18 -compat=1.18; \
done; \
git diff --exit-code;
.PHONY: mod-tidy
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go

go 1.19
go 1.18

require (
github.com/gin-gonic/gin v1.8.1
Expand Down
2 changes: 1 addition & 1 deletion otel/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/otel

go 1.19
go 1.18

require (
github.com/getsentry/sentry-go v0.18.0
Expand Down
9 changes: 0 additions & 9 deletions otel/internal/dummy/dummy.go

This file was deleted.

0 comments on commit 0a44c63

Please sign in to comment.