fix: stack-trace in_app false being omitted (#647)

getsentry · Jun 5, 2023 · 1b0b536 · 1b0b536
1 parent 02e712a
commit 1b0b536
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Bug fixes
+
+- Fix frames recognized as not being in-app still showing as in-app ([#647](https://github.com/getsentry/sentry-go/pull/647))
+
 ## 0.21.0
 
 The Sentry SDK team is happy to announce the immediate availability of Sentry Go SDK v0.21.0.

diff --git a/stacktrace.go b/stacktrace.go
@@ -174,7 +174,7 @@ type Frame struct {
 	PreContext  []string               `json:"pre_context,omitempty"`
 	ContextLine string                 `json:"context_line,omitempty"`
 	PostContext []string               `json:"post_context,omitempty"`
-	InApp       bool                   `json:"in_app,omitempty"`
+	InApp       bool                   `json:"in_app"`
 	Vars        map[string]interface{} `json:"vars,omitempty"`
 	// Package and the below are not used for Go stack trace frames.  In
 	// other platforms it refers to a container where the Module can be

diff --git a/stacktrace_test.go b/stacktrace_test.go
@@ -230,6 +230,7 @@ func TestEventWithExceptionStacktraceMarshalJSON(t *testing.T) {
 		`"vars":{"fooint":25,"foostr":"bar"}` +
 		`},{` +
 		`"symbol":"nativesym",` +
+		`"in_app":false,` +
 		`"package":"my.dylib",` +
 		`"instruction_addr":"0xabcd0010",` +
 		`"addr_mode":"abs",` +