Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set transaction_info.source on scope.SetTransaction call #511

Closed
cleptric opened this issue Dec 6, 2022 · 1 comment
Closed

Set transaction_info.source on scope.SetTransaction call #511

cleptric opened this issue Dec 6, 2022 · 1 comment
Assignees
@tonyo
Labels
Status: Backlog Type: Improvement

Comments

@cleptric
Copy link
Member

cleptric commented Dec 6, 2022

When calling span.SetTransaction(), we should update the Source to SourceCustom.
@cleptric cleptric self-assigned this Dec 6, 2022
@cleptric cleptric assigned tonyo and unassigned cleptric Dec 9, 2022
@tonyo tonyo mentioned this issue May 9, 2023
Merged
@tonyo
Copy link
Contributor

tonyo commented May 15, 2023

SetTransaction is removed anyway, but here's also an improvement to make sure that we always have a proper transaction source: #637

@tonyo tonyo closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyo tonyo

Labels
Status: Backlog Type: Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonyo @cleptric