fix(tracing): Make sure a valid source is set on a transaction event #637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction source should be one of the predefined values as described by the envelopes protocol: https://develop.sentry.dev/sdk/event-payloads/transaction/#transaction-annotations
The safest way to do for Go seems to be checking the source in
Span.toEvent()
: we don't currently have setters forSpan.Name
andSpan.Source
, so adjusting the source earlier may be not enough.Fixes #588
Related to #511