-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add BeforeSendTransaction hook #517
Conversation
`beforeSendTransaction` works similarly to `beforeSend`, but it is applied only to transaction events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there already a docs PR for this?
CHANGELOG.md
Outdated
|
||
### Features | ||
|
||
* Add `beforeSendTransaction` hook ([#517](https://github.com/getsentry/sentry-go/pull/517)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding a small snippet on how to use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess adding a link that point to the docs (when they're ready) should be enough?
This change doesn't seem to be too important or breaking enough to cover it in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like our changelogs to be a bit more telling, especially when it comes to new features. The Ruby SDK is a good benchmark we should aim for https://github.com/getsentry/sentry-ruby/releases
Maybe we could add the new hook to some example in the repo and point to it?
The docs are not very good at showing the actual use of this.
sentry-go/example/feature-showcase/main.go
Line 116 in 6588be3
func main() { |
Added an example and updated the changelog. |
BeforeSendTransaction
works similarly toBeforeSend
, but it is applied only to transaction events.Closes #500.
Docs: