fix(dynamic-sampling): Do not crash in Span.Finish() when Client is empty #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
reviewed
Jan 9, 2023
There was a problem hiding this comment.
This will attach the DSC to the event here
Line 404 in 6588be3
In the transport, we'll skip attaching the DSC as it's empty
https://github.com/getsentry/sentry-go/blob/master/transport.go#L103
I think this is a feasible solution.
tonyo
changed the title
tonyo
changed the title
tonyo
commented
Jan 9, 2023
| if client == nil || scope == nil { | ||
| return DynamicSamplingContext{ | ||
| Entries: map[string]string{}, | ||
| Frozen: false, |
There was a problem hiding this comment.
Made it more explicit to make sure there are no default-value surprises.
cleptric
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a draft since I'm not entirely sure if there are any other places right now where we might have this issue, and also because I'll have to confirm what DynamicSamplingContext to return when Client or Scope are empty.Should be ready for review now.
Fixes #518.