Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Add a new SpanOption: SpanSampled #546

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Jan 23, 2023

A new SpanOption needed for the OTel work (#537).
Can be used to control the sampling flag when creating a new transaction.

@tonyo tonyo requested a review from cleptric January 23, 2023 18:43
@tonyo tonyo self-assigned this Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 78.42% // Head: 78.45% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (ab0ccce) compared to base (ccb6055).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   78.42%   78.45%   +0.02%     
==========================================
  Files          22       22              
  Lines        2939     2943       +4     
==========================================
+ Hits         2305     2309       +4     
  Misses        539      539              
  Partials       95       95              
Impacted Files Coverage Δ
tracing.go 85.03% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo tonyo merged commit 907ce4a into master Jan 24, 2023
@tonyo tonyo deleted the tonyo/spanoption-sampled branch January 24, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants