fix: Clone scope.Context in multiple places to avoid concurrent reads/writes #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #570
Here we introduce
cloneContext
that should be used in multiple places to avoid issues like in #570.Note:
cloneContext
does not do a deep copy ofContext
values (which are of typeinterface{}
), so there are cases where it's still possible to catch panics if you do weird things withContext
values. But this, I believe, is out of scope of the SDK responsibility.