-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HTTP Hijacker interface #837
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
==========================================
+ Coverage 81.76% 81.98% +0.22%
==========================================
Files 50 51 +1
Lines 4436 4507 +71
==========================================
+ Hits 3627 3695 +68
- Misses 661 663 +2
- Partials 148 149 +1 ☔ View full report in Codecov by Sentry. |
The only difference between this (and previous incomplete Wrapper) and Chi's is that this defaults to 200 instead of 0 if WriteHeader has not yet been called. |
Is this fix working transparently? or requires some extra initialization? |
I just checked and it seems you're right, I've updated the implementation for stdlib but not for negroni. I'll submit a fix today. |
Resolves #836
Was able to reproduce it with 0.28.0 (
Error accepting websocket connection: failed to accept WebSocket connection: http.ResponseWriter does not implement http.Hijacker
) and see it resolved with this fix.