VendorId should be a String

[markushi]

📜 Description

gpu.vendorId was defined as an Int, should be a String.

💡 Motivation and Context

This is a breaking change but I'm wondering if anyone is using it. We could introduce a @Deprecated void setVendorId(int vendorId) { setVendorId(String.valueOf(vendorId)); } to minimize the impact, but I'm not sure if it's worth it.

Mobile Issue: getsentry/team-mobile#67
Dart: getsentry/sentry-dart#1112

💚 How did you test it?

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• No breaking changes

🔮 Next steps

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	319.39 ms	377.51 ms	58.12 ms
Size	1.73 MiB	2.32 MiB	609.88 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
7597ded	289.60 ms	339.69 ms	50.09 ms
90e9745	314.68 ms	357.28 ms	42.60 ms
f809aac	301.51 ms	346.60 ms	45.09 ms

App size

Revision	Plain	With Sentry	Diff
7597ded	1.73 MiB	2.32 MiB	609.88 KiB
90e9745	1.73 MiB	2.32 MiB	608.63 KiB
f809aac	1.73 MiB	2.32 MiB	608.63 KiB

Previous results on branch: fix/vendor-id

Startup times

Revision	Plain	With Sentry	Diff
a71440b	364.43 ms	414.54 ms	50.11 ms
cf24825	349.34 ms	390.02 ms	40.68 ms
cc533e1	319.79 ms	360.70 ms	40.91 ms

App size

Revision	Plain	With Sentry	Diff
a71440b	1.73 MiB	2.32 MiB	609.88 KiB
cf24825	1.73 MiB	2.32 MiB	609.88 KiB
cc533e1	1.73 MiB	2.32 MiB	609.88 KiB

[romtsn]

I'm fine with the breaking change not being in major, @marandaneto what do you say?

[marandaneto]

This is a breaking change but I'm wondering if anyone is using it. We could introduce a @Deprecated void setVendorId(int vendorId) { setVendorId(String.valueOf(vendorId)); } to minimize the impact, but I'm not sure if it's worth it.

I like the idea:

This is a breaking change but I'm wondering if anyone is using it. We could introduce a @deprecated void setVendorId(int vendorId) { setVendorId(String.valueOf(vendorId)); } to minimize the impact, but I'm not sure if it's worth it.

But I dont think anyone is using it directly, Dart has no overloads, so I considered a bug fix because right now it does not work anyway.