-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beforeSendTransaction which allows users to filter and change transactions #2388
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
507f924 | 342.51 ms | 402.65 ms | 60.14 ms |
b85d8aa | 289.35 ms | 335.92 ms | 46.56 ms |
4a9c176 | 320.62 ms | 334.68 ms | 14.06 ms |
7597ded | 289.60 ms | 339.69 ms | 50.09 ms |
3695453 | 299.25 ms | 360.04 ms | 60.79 ms |
f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
3695453 | 314.63 ms | 353.10 ms | 38.47 ms |
3695453 | 301.78 ms | 371.14 ms | 69.36 ms |
4a9c176 | 319.77 ms | 363.20 ms | 43.43 ms |
90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
507f924 | 1.73 MiB | 2.32 MiB | 609.95 KiB |
b85d8aa | 1.73 MiB | 2.32 MiB | 611.62 KiB |
4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
7597ded | 1.73 MiB | 2.32 MiB | 609.88 KiB |
3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
Codecov ReportBase: 80.24% // Head: 80.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
============================================
+ Coverage 80.24% 80.28% +0.04%
- Complexity 3690 3695 +5
============================================
Files 292 292
Lines 13853 13890 +37
Branches 1836 1839 +3
============================================
+ Hits 11116 11152 +36
Misses 2021 2021
- Partials 716 717 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
📜 Description
Similar to
beforeSend
for errorsbeforeSendTransaction
allows users to change and filter transactions.💡 Motivation and Context
Closes #2358
💚 How did you test it?
Unit tests, ran sample
📝 Checklist
🔮 Next steps