Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beforeSendTransaction which allows users to filter and change transactions #2388

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

adinauer
Copy link
Member

📜 Description

Similar to beforeSend for errors beforeSendTransaction allows users to change and filter transactions.

💡 Motivation and Context

Closes #2358

💚 How did you test it?

Unit tests, ran sample

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c83f2ba

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 373.33 ms 470.04 ms 96.71 ms
Size 1.73 MiB 2.32 MiB 612.15 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
507f924 342.51 ms 402.65 ms 60.14 ms
b85d8aa 289.35 ms 335.92 ms 46.56 ms
4a9c176 320.62 ms 334.68 ms 14.06 ms
7597ded 289.60 ms 339.69 ms 50.09 ms
3695453 299.25 ms 360.04 ms 60.79 ms
f809aac 301.51 ms 346.60 ms 45.09 ms
3695453 314.63 ms 353.10 ms 38.47 ms
3695453 301.78 ms 371.14 ms 69.36 ms
4a9c176 319.77 ms 363.20 ms 43.43 ms
90e9745 314.68 ms 357.28 ms 42.60 ms

App size

Revision Plain With Sentry Diff
507f924 1.73 MiB 2.32 MiB 609.95 KiB
b85d8aa 1.73 MiB 2.32 MiB 611.62 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
7597ded 1.73 MiB 2.32 MiB 609.88 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
f809aac 1.73 MiB 2.32 MiB 608.63 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
3695453 1.73 MiB 2.32 MiB 611.62 KiB
4a9c176 1.73 MiB 2.33 MiB 612.69 KiB
90e9745 1.73 MiB 2.32 MiB 608.63 KiB

Previous results on branch: feat/add-before-send-transaction

Startup times

Revision Plain With Sentry Diff
92bac29 342.22 ms 380.43 ms 38.20 ms
96f3228 315.83 ms 360.46 ms 44.63 ms

App size

Revision Plain With Sentry Diff
92bac29 1.73 MiB 2.32 MiB 612.15 KiB
96f3228 1.73 MiB 2.32 MiB 612.15 KiB

@codecov-commenter
Copy link

Codecov Report

Base: 80.24% // Head: 80.28% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (e5f2f86) compared to base (3695453).
Patch coverage: 97.29% of modified lines in pull request are covered.

❗ Current head e5f2f86 differs from pull request most recent head c4c253e. Consider uploading reports for the commit c4c253e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2388      +/-   ##
============================================
+ Coverage     80.24%   80.28%   +0.04%     
- Complexity     3690     3695       +5     
============================================
  Files           292      292              
  Lines         13853    13890      +37     
  Branches       1836     1839       +3     
============================================
+ Hits          11116    11152      +36     
  Misses         2021     2021              
- Partials        716      717       +1     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryClient.java 86.02% <96.15%> (+0.67%) ⬆️
...y/spring/boot/jakarta/SentryAutoConfiguration.java 98.46% <100.00%> (+0.02%) ⬆️
...io/sentry/spring/boot/SentryAutoConfiguration.java 98.46% <100.00%> (+0.02%) ⬆️
...ry/spring/jakarta/SentryInitBeanPostProcessor.java 97.56% <100.00%> (+0.19%) ⬆️
.../io/sentry/spring/SentryInitBeanPostProcessor.java 97.56% <100.00%> (+0.19%) ⬆️
sentry/src/main/java/io/sentry/SentryOptions.java 81.21% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@adinauer adinauer merged commit b39d6a0 into main Nov 28, 2022
@adinauer adinauer deleted the feat/add-before-send-transaction branch November 28, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add beforeSendTransaction
3 participants