-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling): Remove SentryOptions deps from AndroidProfiler #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependent' into kw-refactor-make-profiler-tx-independent
…ependent' into kw-refactor-make-profiler-tx-independent
…iler-tx-independent
krystofwoldrich
requested review from
adinauer,
romtsn,
stefanosiano and
markushi
as code owners
November 15, 2023 11:31
krystofwoldrich
changed the title
chore(profiling): Create independent Profiler for Hybrid SDKs
feature(profiling): Remove SentryOptions deps from AndroidProfiler
Nov 15, 2023
krystofwoldrich
changed the title
feature(profiling): Remove SentryOptions deps from AndroidProfiler
fix(profiling): Remove SentryOptions deps from AndroidProfiler
Nov 15, 2023
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
99a51e2 | 405.11 ms | 479.65 ms | 74.54 ms |
4bf95dd | 345.96 ms | 414.24 ms | 68.28 ms |
c7e2fbc | 398.35 ms | 468.52 ms | 70.17 ms |
a3c77bc | 375.80 ms | 445.85 ms | 70.06 ms |
93a76ca | 378.48 ms | 451.78 ms | 73.30 ms |
c3f503e | 360.41 ms | 434.67 ms | 74.27 ms |
93a76ca | 397.30 ms | 455.16 ms | 57.87 ms |
3d8bd2b | 364.76 ms | 469.98 ms | 105.22 ms |
c7e2fbc | 372.00 ms | 461.71 ms | 89.71 ms |
7ca9895 | 364.31 ms | 460.46 ms | 96.15 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
99a51e2 | 1.72 MiB | 2.29 MiB | 576.34 KiB |
4bf95dd | 1.72 MiB | 2.29 MiB | 576.40 KiB |
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
a3c77bc | 1.72 MiB | 2.29 MiB | 577.53 KiB |
93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
c3f503e | 1.72 MiB | 2.29 MiB | 577.04 KiB |
93a76ca | 1.72 MiB | 2.29 MiB | 576.75 KiB |
3d8bd2b | 1.72 MiB | 2.29 MiB | 577.53 KiB |
c7e2fbc | 1.72 MiB | 2.29 MiB | 576.40 KiB |
7ca9895 | 1.72 MiB | 2.29 MiB | 576.51 KiB |
Previous results on branch: kw-hybrid-profiling
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
64dd83e | 387.84 ms | 466.16 ms | 78.32 ms |
d6884f8 | 387.10 ms | 453.73 ms | 66.63 ms |
ce7d724 | 396.55 ms | 476.31 ms | 79.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
64dd83e | 1.72 MiB | 2.29 MiB | 578.47 KiB |
d6884f8 | 1.72 MiB | 2.29 MiB | 578.47 KiB |
ce7d724 | 1.72 MiB | 2.29 MiB | 578.47 KiB |
12 tasks
markushi
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, very clean cut! 🥷
krystofwoldrich
changed the title
fix(profiling): Remove SentryOptions deps from AndroidProfiler
feat(profiling): Remove SentryOptions deps from AndroidProfiler
Nov 15, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR refactors the
AndroidProfiler
interface so HybridSDKs can create the profiler without AndroidSDK initialized.In practice, this means removing
SentryOptions
from the constructor and replacing it with enumerations of the dependencies, which HybridSDKs can create independent of the AndroidSDK.💡 Motivation and Context
This enabled Android/RN mixed profiles.
💚 How did you test it?
RN sample app
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps