Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Cleanups and session deadline #3316

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 4, 2024

#skip-changelog

📜 Description

A few improvements this PR does:

  • Cleans up older replay folders when starting a new one
  • Adds deadline of 1 hour for full session recordings
  • Adds safe wrappers for executors that handle failures gracefully when submitting or executing tasks

💡 Motivation and Context

Part of getsentry/sentry#63255

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 393.33 ms 454.66 ms 61.33 ms
Size 1.70 MiB 2.30 MiB 617.28 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn merged commit bf8f49a into rz/feat/session-replay Apr 9, 2024
22 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-cleanups branch April 9, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants