Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Add redact options and align naming #3328

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 5, 2024

#skip-changelog

📜 Description

  • Align naming (sessionReplay instead of sessionReplayOptions)
  • Add redactAllText and redactAllImages options

💡 Motivation and Context

Part of getsentry/sentry#63255

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 374.76 ms 437.55 ms 62.80 ms
Size 1.70 MiB 2.30 MiB 618.42 KiB

Previous results on branch: rz/feat/session-replay-redact-options

Startup times

Revision Plain With Sentry Diff
ff9aecd 359.28 ms 450.31 ms 91.03 ms
03382fb 320.57 ms 374.67 ms 54.10 ms
891e156 346.82 ms 407.51 ms 60.69 ms

App size

Revision Plain With Sentry Diff
ff9aecd 1.70 MiB 2.30 MiB 617.80 KiB
03382fb 1.70 MiB 2.30 MiB 617.80 KiB
891e156 1.70 MiB 2.30 MiB 617.80 KiB

Base automatically changed from rz/fix/session-replay-media-codec to rz/feat/session-replay April 9, 2024 10:05
@romtsn romtsn merged commit 3ef9f06 into rz/feat/session-replay Apr 9, 2024
19 of 20 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-redact-options branch April 9, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants