Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Expose public API for flutter #3373

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 18, 2024

#skip-changelog

📜 Description

  • Rework ReplayIntegration so it can accept a Recorder as a parameter and be used in e.g. Flutter by reusing most parts of the replay logic from the native layer
  • Make ReplayIntegration testable and add a simple test with a different recorder. This is just a first step to make it testable and cover it with tests

💡 Motivation and Context

Part of getsentry/sentry#63255

💚 How did you test it?

Ivan did

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 363.11 ms 441.60 ms 78.49 ms
Size 1.70 MiB 2.32 MiB 633.47 KiB

Baseline results on branch: rz/feat/session-replay-breadcrumbs

Startup times

Revision Plain With Sentry Diff
40daa25 438.42 ms 513.67 ms 75.25 ms
150dd36 397.04 ms 446.85 ms 49.81 ms

App size

Revision Plain With Sentry Diff
40daa25 1.70 MiB 2.32 MiB 633.29 KiB
150dd36 1.70 MiB 2.32 MiB 633.30 KiB

Previous results on branch: rz/feat/session-replay-public-api

Startup times

Revision Plain With Sentry Diff
a82aaa3 341.67 ms 403.26 ms 61.59 ms

App size

Revision Plain With Sentry Diff
a82aaa3 1.70 MiB 2.32 MiB 633.46 KiB

@romtsn romtsn force-pushed the rz/feat/session-replay-breadcrumbs branch from b3b7813 to 4c7d1a0 Compare April 18, 2024 16:29
Base automatically changed from rz/feat/session-replay-breadcrumbs to rz/feat/session-replay April 25, 2024 10:07
@romtsn romtsn merged commit 33cd776 into rz/feat/session-replay Apr 25, 2024
21 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-public-api branch April 25, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants