-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report suppressed exceptions as exception group #3396
Conversation
…pes-merge-2-add-scopes
…ainScopes to rootScopes
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Report suppressed exceptions as exception group ([#3396](https://github.com/getsentry/sentry-java/pull/3396)) If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0a61517 | 394.71 ms | 454.42 ms | 59.71 ms |
37d1e27 | 379.49 ms | 423.67 ms | 44.18 ms |
99b5ed4 | 386.04 ms | 460.83 ms | 74.79 ms |
25e1771 | 383.98 ms | 459.50 ms | 75.52 ms |
1c2fbfe | 403.73 ms | 463.84 ms | 60.11 ms |
a23c145 | 396.22 ms | 458.98 ms | 62.76 ms |
702ae01 | 403.63 ms | 476.15 ms | 72.51 ms |
c822b54 | 431.59 ms | 549.47 ms | 117.88 ms |
0c124b6 | 382.98 ms | 458.90 ms | 75.92 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0a61517 | 1.70 MiB | 2.28 MiB | 595.98 KiB |
37d1e27 | 1.70 MiB | 2.28 MiB | 595.95 KiB |
99b5ed4 | 1.70 MiB | 2.28 MiB | 595.99 KiB |
25e1771 | 1.70 MiB | 2.28 MiB | 595.98 KiB |
1c2fbfe | 1.70 MiB | 2.28 MiB | 595.99 KiB |
a23c145 | 1.70 MiB | 2.28 MiB | 595.97 KiB |
702ae01 | 1.70 MiB | 2.28 MiB | 595.97 KiB |
c822b54 | 1.70 MiB | 2.28 MiB | 595.97 KiB |
0c124b6 | 1.70 MiB | 2.28 MiB | 595.97 KiB |
Do we have an ETA for when it can be merged and released? |
@rodolfoBee since we're merging this into |
@rodolfoBee we just discussed this internally and we're planning to merge this sooner and do an alpha release without Performance powered by OpenTelemetry. Just need to prepare some things for the release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
📜 Description
Report exceptions returned by
Throwable.getSuppressed()
to Sentry as exception groups. They show up like this:Links can be clicked and take you to the exception on the same page.
💡 Motivation and Context
Fixes #542
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps