-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] Move NDK scope sync to background thread #3754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
October 4, 2024 07:57
|
romtsn
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just thinking if we should introduce an ndk-specific executor here? Our default executor does too many things already 😅
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3a599c8 | 662.49 ms | 748.14 ms | 85.65 ms |
4139c9c | 425.58 ms | 460.88 ms | 35.29 ms |
57a3722 | 394.68 ms | 462.96 ms | 68.28 ms |
d28a94e | 411.56 ms | 428.00 ms | 16.44 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3a599c8 | 1.70 MiB | 2.35 MiB | 661.36 KiB |
4139c9c | 1.70 MiB | 2.35 MiB | 661.36 KiB |
57a3722 | 1.70 MiB | 2.35 MiB | 667.55 KiB |
d28a94e | 1.70 MiB | 2.35 MiB | 661.36 KiB |
stefanosiano
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Utilizes our ExecutorService to perform NDK scope sync (and it's JSON serialization) on a background thread.
This will cause an async scope sync, meaning if e.g.
.setUser()
returns, the value is not visible on the NDK side right away. The upside is faster execution.If we see there's demand for an in-sync solution, we can introduce a flag later.
Motivation
Closes #3046
💚 How did you test it?
Extended tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps