Bump Gradle 8.9, AGP 8.6.0, Kotlin 1.9.22 #3839
Conversation
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
buildSrc/src/main/java/Config.kt
Outdated
| val kotlinStdLib = "stdlib-jdk8" | ||
|
|
||
| val springBootVersion = "2.7.5" | ||
| val springBoot3Version = "3.3.2" | ||
| val kotlinCompatibleLanguageVersion = "1.4" | ||
| val kotlinCompatibleLanguageVersion = "1.5" |
There was a problem hiding this comment.
I guess this deserves a "Breaking changes" note at least? doubt anyone is still on this version, but gotta call it out (or make it part of v8?)
build.gradle.kts
Outdated
| @@ -154,8 +152,9 @@ subprojects { | |||
| } | |||
| } | |||
|
|
|||
| if (!this.name.contains("sample") && !this.name.contains("integration-tests") && this.name != "sentry-test-support" && this.name != "sentry-compose-helper") { | |||
| if (!this.name.contains("sample") && !this.name.contains("integration-tests") && this.name != "sentry-test-support" && this.name != "sentry-compose-helper" && this.name != "sentry-bom") { | |||
There was a problem hiding this comment.
not needed for sentry-bom anymore?
There was a problem hiding this comment.
I added this due to sentry-bom defining it's own maven publication, causing a duplicate publication error. But actually that's not needed anymore, so I'll remove it from sentry-bom/build.gradle instead 👍
| <uses-permission android:name="android.permission.INTERNET"/> | ||
|
|
||
| <!-- Compose requires min SDK 21, but Sentry requires min SDK 19 --> | ||
| <uses-sdk tools:overrideLibrary="androidx.compose.runtime" /> |
There was a problem hiding this comment.
is this needed only for tests/sample apps?
Yeah I tried local publishing and compared some files side-by-side. Looking good! One difference I've seen: The |
Oh that's nice, it probably fixes this issue? #3785 |
📜 Description
androidx.benchmarkrequires a newer version of AGP for micro benchmarks. Bumping all required deps as well.💡 Motivation and Context.
New features and faster builds.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog