Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new APIs for Continuous Profiling v8 (p5) #3844

Open
wants to merge 3 commits into
base: feat/continuous-profiling-part4
Choose a base branch
from

Conversation

stefanosiano
Copy link
Member

📜 Description

added Sentry.startProfiler and Sentry.stopProfiler APIs
AndroidContinuousProfiler now checks the scopes (and options) on profile start

#skip-changelog

💡 Motivation and Context

Implements user APIs for Continuous Profiling
Part 5 of #3683

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

added Sentry.startProfile() API
removed profilesSampleRate from sample app to enable continuous profiling
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4cc9735

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 407.14 ms 450.20 ms 43.06 ms
Size 1.70 MiB 2.36 MiB 672.24 KiB

@stefanosiano stefanosiano marked this pull request as ready for review November 4, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant