Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 16kb page size for Android 15 (8.x.x) #3851

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Support 16kb page size for Android 15 (8.x.x) #3851

merged 2 commits into from
Nov 6, 2024

Conversation

markushi
Copy link
Member

@markushi markushi commented Nov 6, 2024

📜 Description

Counterpart to 7.x.x PR #3620
Also increases the minSdk version to 21.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@markushi markushi changed the base branch from main to 8.x.x November 6, 2024 08:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 486c1e0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 444.73 ms 505.47 ms 60.74 ms
Size 1.70 MiB 2.30 MiB 617.43 KiB

@markushi markushi added this to the 8.0.0 milestone Nov 6, 2024
@markushi markushi merged commit 254787a into 8.x.x Nov 6, 2024
23 checks passed
@markushi markushi deleted the feat/support_16kb_page_size_8xx branch November 6, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanosiano stefanosiano stefanosiano approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@markushi @stefanosiano