Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 52 - Do not ignore certain span origins for OTel without Agent #3856

Open
wants to merge 4 commits into
base: feat/spring-boot-autoconfig-for-otel-no-agent
Choose a base branch
from

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Nov 7, 2024

📜 Description

  • Do not ignore certain span origins for OTel without Agent
  • Add a separate sample for "no agent" use case

💡 Motivation and Context

  • Not all auto instrumentation is there for the Spring setup without an agent
  • Avoids having to change a single sample back and forth.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…or no agent

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 52 - Do not ignore certain span origins for OTel without Agent ([#3856](https://github.com/getsentry/sentry-java/pull/3856))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2a28512

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 470.16 ms 498.78 ms 28.62 ms
Size 1.70 MiB 2.36 MiB 670.63 KiB

Baseline results on branch: feat/spring-boot-autoconfig-for-otel-no-agent

Startup times

Revision Plain With Sentry Diff
fe6463f 408.02 ms 421.84 ms 13.82 ms

App size

Revision Plain With Sentry Diff
fe6463f 1.70 MiB 2.36 MiB 670.64 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant