Skip to content

Commit

Permalink
fix(ci): Exclude config/types.ts in @sentry/nextjs from circular …
Browse files Browse the repository at this point in the history
…dependency check (#4598)

The library we use to detect circular dependencies, `madge`, has a bug wherein local files whose names match node modules cause false positives. (For more details, see pahen/madge#306.) In our case, it was triggered by #4597, which added an export from  file (`config/types.ts`) which depends on the node module `webpack` and which is depended upon by the local file `config/webpack.ts`.

To solve this for the moment, this excludes the problematic file from the check.
  • Loading branch information
lobsterkatie authored Feb 16, 2022
1 parent 3e481e4 commit af6c24f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"build:dev:watch": "run-s build:watch",
"build:es5:watch": "yarn build:cjs:watch # *** backwards compatibility - remove in v7 ***",
"build:esm:watch": "tsc -p tsconfig.esm.json --watch",
"circularDepCheck": "madge --circular src/index.client.ts && madge --circular src/index.server.ts",
"circularDepCheck": "madge --circular src/index.client.ts && madge --circular --exclude 'config/types\\.ts' src/index.server.ts # see https://github.com/pahen/madge/issues/306",
"clean": "rimraf dist esm coverage *.js *.js.map *.d.ts",
"fix": "run-s fix:eslint fix:prettier",
"fix:eslint": "eslint . --format stylish --fix",
Expand Down

0 comments on commit af6c24f

Please sign in to comment.