adding shouldHandleError to setupExpressErrorHandler in @sentry/node v8

[xmunoz]

Prior to upgrading our SDK to v8, our Sentry error handler looked like this:

const sentry = Sentry.Handlers.errorHandler({
  shouldHandleError(error) {
    // Capture errors without HTTP status, >=400 errors
    if (!error.status || error.status >= 400) {
      return true;
    }

    return false;
  },
});
app.use(sentry);

I'm having a hard time replicating this configuration since migrating the SDK to v8. Is this still possible?

[xmunoz]

Here is what I implemented in v8 to get this working the same way:

const sentry = Sentry.expressErrorHandler({
  shouldHandleError(error) {
    // Capture errors without HTTP status, >=400 errors
    if (!error.status || error.status >= 400) {
      return true;
    }

    return false;
  },
});
app.use(sentry);

[mydea]

Hey, yes this is exactly right and the way to go here!

We could expose the option on setupExpressErrorHandler as well, I believe! If you want we'd happily accept a PR to add this as an optional second arg. Other than this, for now, manually setting this up like this is totally fine.

[kYem]

I think it would be useful to add it to the migration docs https://docs.sentry.io/platforms/javascript/guides/express/migration/v7-to-v8/