Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of support for http.request.method in OTel span processor #11926

Closed
3 tasks done
jeengbe opened this issue May 7, 2024 · 4 comments
Closed
3 tasks done

Backport of support for http.request.method in OTel span processor #11926

jeengbe opened this issue May 7, 2024 · 4 comments
Labels
Package: node Issues related to the Sentry Node SDK Type: Bug

Comments

@jeengbe
Copy link
Contributor

jeengbe commented May 7, 2024

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

latest

Framework Version

n/a

Link to Sentry event

n/a

Issue

Please also support http.request.method instead of only http.method in v7.

Fix: https://github.com/getsentry/sentry-javascript/blob/develop/packages/opentelemetry/src/utils/parseSpanDescription.ts#L41

Old code: https://github.com/getsentry/sentry-javascript/blob/v7/packages/opentelemetry-node/src/utils/parseOtelSpanDescription.ts#L27

Should take no more than a couple of minutes 🙂

@github-actions github-actions bot added the Package: node Issues related to the Sentry Node SDK label May 7, 2024
@mydea
Copy link
Member

mydea commented May 7, 2024

Do you mind opening a PR for this? I'll happily approve and merge it for you!
We are very busy right now with preparing the stable v8 release at the moment :)

@jeengbe
Copy link
Contributor Author

jeengbe commented May 7, 2024

Will do, no worries 🙂

@jeengbe
Copy link
Contributor Author

jeengbe commented May 7, 2024

Fixed

@mydea
Copy link
Member

mydea commented May 7, 2024

This will go out with the next backport release, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: node Issues related to the Sentry Node SDK Type: Bug
Projects
Archived in project
Development

No branches or pull requests

2 participants