Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename component.json to bower.json #134

Closed
dmitry-dedukhin opened this issue Sep 23, 2013 · 9 comments
Closed

Rename component.json to bower.json #134

dmitry-dedukhin opened this issue Sep 23, 2013 · 9 comments

Comments

@dmitry-dedukhin
Copy link

According to http://bower.io/#defining-a-package

@bencevans
Copy link

👍

@bencevans
Copy link

Receving warnings when installing from Bower now:

➜  [REDACTED] git:([REDACTED]) bower install --save raven-js
...
bower raven-js#*            deprecated Package raven-js is using the deprecated component.json
...
bower raven-js#*              resolved git://github.com/getsentry/raven-js.git#1.0.8
bower raven-js#~1.0.8          install raven-js#1.0.8

@bencevans
Copy link

I'm quite happy to submit a pull-request if it won't be done otherwise, just need to know whether to move the component.json file or duplicate it? Due to people using TJ's 'component' module system.

@mattrobenolt
Copy link
Contributor

I honestly know nothing about bower or component, so I'd be looking for the best recommendation here.

@bencevans
Copy link

I'd recommend duplicating as that can't hurt anyone using the component.json currently.

@mattrobenolt
Copy link
Contributor

Is it literally identical in format? So does that mean I have to bump versions in both of them, etc. Can you just use a symlink if they're identical?

@mattrobenolt
Copy link
Contributor

All around, that seems kinda silly. What do other people do in more popular libraries? I'm sure there's a recommended way of doing this.

@bencevans
Copy link

jQuery seem to have just gone with the bower.json file without a component.json ... https://github.com/jquery/jquery

@mattrobenolt
Copy link
Contributor

That's fair. Wanna submit a PR? I'd be open to any suggestions/recommendations for contents within the bower.json file as well.

billyvg added a commit that referenced this issue Dec 12, 2023
> * Revert "fix: isCheckout is not included in fullsnapshot event (rrweb-io#1141)"

Fixes an issue where Meta event is being lost in buffered replays.

> revert: feat: Remove plugins related code, which is not used #123
> feat: Export additional canvas-related types and functions (#134)

Changes needed for canvas playback

> feat: Skip addHoverClass when stylesheet is >= 1MB #130

Affects playback only
billyvg added a commit that referenced this issue Dec 12, 2023
> * Revert "fix: isCheckout is not included in fullsnapshot event
(rrweb-io#1141)"

Fixes an issue where Meta event is being lost in buffered replays.

> revert: feat: Remove plugins related code, which is not used #123
> feat: Export additional canvas-related types and functions (#134)

Changes needed for canvas playback

> feat: Skip addHoverClass when stylesheet is >= 1MB #130

Affects playback only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants