-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename component.json to bower.json #134
Comments
👍 |
Receving warnings when installing from Bower now:
|
I'm quite happy to submit a pull-request if it won't be done otherwise, just need to know whether to move the component.json file or duplicate it? Due to people using TJ's 'component' module system. |
I honestly know nothing about bower or component, so I'd be looking for the best recommendation here. |
I'd recommend duplicating as that can't hurt anyone using the component.json currently. |
Is it literally identical in format? So does that mean I have to bump versions in both of them, etc. Can you just use a symlink if they're identical? |
All around, that seems kinda silly. What do other people do in more popular libraries? I'm sure there's a recommended way of doing this. |
jQuery seem to have just gone with the bower.json file without a component.json ... https://github.com/jquery/jquery |
That's fair. Wanna submit a PR? I'd be open to any suggestions/recommendations for contents within the bower.json file as well. |
> * Revert "fix: isCheckout is not included in fullsnapshot event (rrweb-io#1141)" Fixes an issue where Meta event is being lost in buffered replays. > revert: feat: Remove plugins related code, which is not used #123 > feat: Export additional canvas-related types and functions (#134) Changes needed for canvas playback > feat: Skip addHoverClass when stylesheet is >= 1MB #130 Affects playback only
> * Revert "fix: isCheckout is not included in fullsnapshot event (rrweb-io#1141)" Fixes an issue where Meta event is being lost in buffered replays. > revert: feat: Remove plugins related code, which is not used #123 > feat: Export additional canvas-related types and functions (#134) Changes needed for canvas playback > feat: Skip addHoverClass when stylesheet is >= 1MB #130 Affects playback only
According to http://bower.io/#defining-a-package
The text was updated successfully, but these errors were encountered: