Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nestjs): Exception filters in main app module are not being executed #13278

Merged
merged 36 commits into from
Aug 13, 2024
Merged

fix(nestjs): Exception filters in main app module are not being executed #13278

merged 36 commits into from
Aug 13, 2024

Commits on Aug 8, 2024

  1. Add test that demonstrates wrong behavior

    @nicohrubec
    nicohrubec committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6e6b32e View commit details
    Browse the repository at this point in the history

  2. Use example exception instead of bad request

    @nicohrubec
    nicohrubec committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fd3a30a View commit details
    Browse the repository at this point in the history

  3. Rename

    @nicohrubec
    nicohrubec committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1bcaf37 View commit details
    Browse the repository at this point in the history

  4. Add local filter test

    @nicohrubec
    nicohrubec committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    22eadbe View commit details
    Browse the repository at this point in the history

  5. Fix tests

    @nicohrubec
    nicohrubec committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    61d5fe6 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Start on base exception filter patch

    @nicohrubec
    nicohrubec committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    885fb6b View commit details
    Browse the repository at this point in the history

  2. Basic patch for base exception filter seems to work (we can log somet… 

    …hing)
    @nicohrubec
    nicohrubec committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d4ab597 View commit details
    Browse the repository at this point in the history

  3. This works! (I think)

    @nicohrubec
    nicohrubec committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c9b690f View commit details
    Browse the repository at this point in the history

  4. Adding correct logic to patch

    @nicohrubec
    nicohrubec committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e73698a View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @nicohrubec
    nicohrubec committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f71297e View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Fix tests to reflect new working state

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    1c87a97 View commit details
    Browse the repository at this point in the history

  2. Remove nest microservice dependency

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    83998d2 View commit details
    Browse the repository at this point in the history

  3. Add docstrings and improve deprecation message

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    5be4440 View commit details
    Browse the repository at this point in the history

  4. Pass all arguments

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    daf1156 View commit details
    Browse the repository at this point in the history

  5. Add test for instrumentation in module registered before Sentry

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    468fb30 View commit details
    Browse the repository at this point in the history

  6. Lint2

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    1f47da1 View commit details
    Browse the repository at this point in the history

  7. Remove note about registration order from readme

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    75058b4 View commit details
    Browse the repository at this point in the history

  8. Add tests to node sdk

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    20891b3 View commit details
    Browse the repository at this point in the history

  9. Rename error isntrumentation

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    6d1a150 View commit details
    Browse the repository at this point in the history

  10. Default base filter to undefined

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ddf23b2 View commit details
    Browse the repository at this point in the history

  11. Add comment

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2b5d119 View commit details
    Browse the repository at this point in the history

  12. Revert some stuff

    @nicohrubec
    nicohrubec committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8fa920a View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Update to decorator and explicit sentry global filter provider

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d7a6263 View commit details
    Browse the repository at this point in the history

  2. make stuff not broken

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    47481fa View commit details
    Browse the repository at this point in the history

  3. Revert node tests

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2d4dc35 View commit details
    Browse the repository at this point in the history

  4. Update tests

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    eb72826 View commit details
    Browse the repository at this point in the history

  5. Add sample application with new decorator setup

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    66fa8bb View commit details
    Browse the repository at this point in the history

  6. Fix tests?

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    38d0093 View commit details
    Browse the repository at this point in the history

  7. Add test: Unexpected exception not caught by local filter is reported

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    fbc5a7a View commit details
    Browse the repository at this point in the history

  8. Add specific filter test

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b09bb16 View commit details
    Browse the repository at this point in the history

  9. Add test local filter

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    878ee0b View commit details
    Browse the repository at this point in the history

  10. Rename decorator

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    56a823c View commit details
    Browse the repository at this point in the history

  11. Make decorator nicer

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    45de32e View commit details
    Browse the repository at this point in the history

  12. Update readme

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0b49d0d View commit details
    Browse the repository at this point in the history

  13. Update readme

    @lforst
    lforst committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    570de0e View commit details
    Browse the repository at this point in the history

  14. Remove useless files

    @nicohrubec
    nicohrubec committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    242e62e View commit details
    Browse the repository at this point in the history