Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Allow adding measurements without global client #13612

Merged
merged 2 commits into from
Sep 9, 2024
Merged

feat(core): Allow adding measurements without global client #13612

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6fbdd8
feat(core): Allow adding measurements without global client
timfish Sep 8, 2024
e0ebe5b
Change docs
timfish Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/core/src/tracing/measurement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import { getActiveSpan, getRootSpan } from '../utils/spanUtils';
/**
* Adds a measurement to the current active transaction.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update the docstring to reflect this.

*/
export function setMeasurement(name: string, value: number, unit: MeasurementUnit): void {
const activeSpan = getActiveSpan();
export function setMeasurement(name: string, value: number, unit: MeasurementUnit, activeSpan = getActiveSpan()): void {
const rootSpan = activeSpan && getRootSpan(activeSpan);

if (rootSpan) {
Expand Down
Loading