ref(nextjs): Improve app router routing instrumentation accuracy #13695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…router-routing-instrumentation
size-limit report 📦
|
chargome
approved these changes
Sep 20, 2024
| }; | ||
| function transactionNameifyRouterArgument(target: string): string { | ||
| try { | ||
| return new URL(target, 'http://some-random-base.com/').pathname; |
There was a problem hiding this comment.
q: Why do we need that exactly? Couldn't we just take the target?
There was a problem hiding this comment.
So users could be passing basically any string to router.push(), including absolute URLs to the current origin. Taking the absolute URLs wouldn't be good, so we somehow need to parse out the path. Parsing urls is really hard so this is the easiest/best way I found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the Next.js routing instrumentation by patching the Next.js router and instrumenting window popstates.
A few details on this PR that might explain weird-looking logic:
router.back/router.forwardand thepopstateevent to emit a properly named transaction, becauserouter.backandrouter.forwardaren't passed any useful strings we could use as txn names.router.back/router.forwardcalls and thepopstateevent, we temporarily give the navigation span an invalid name that we use as an indicator to drop if one may leak through.