Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fetch): Fix memory leak when handling endless streaming #13809

Merged
merged 5 commits into from
Oct 3, 2024
Merged

fix(fetch): Fix memory leak when handling endless streaming #13809

merged 5 commits into from
Oct 3, 2024
+48 −31

Commits on Sep 26, 2024

  1. fix(fetch): Fix memory leak when handling endless streaming 

    This is a quick fix to address a memory overflow issue caused by the recursive approach when handling endless streams (e.g., CCTV).
However, this is not a perfect solution, as this approach still does not trigger the onFinishedResolving callback for streams that never terminate.

Fixes getsentryGH-13806
    @soapproject
    soapproject committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c9874d9 View commit details
    Browse the repository at this point in the history

  2. Update fetch.ts 

    adjust format
    @soapproject
    soapproject authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    335adcc View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Free usage of reader and and define max timeout of 90s

    @lforst
    lforst committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d20c03b View commit details
    Browse the repository at this point in the history

  2. Update tests

    @lforst
    lforst committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    91396d0 View commit details
    Browse the repository at this point in the history

  3. cancel body instead of reader and add comment

    @lforst
    lforst committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1846cd4 View commit details
    Browse the repository at this point in the history