Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sveltekit): add url param to source map upload options #13812

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

obostjancic
Copy link
Member

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@obostjancic obostjancic marked this pull request as ready for review September 27, 2024 07:17
Copy link

codecov bot commented Sep 27, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
231 1 230 8
View the full list of 1 ❄️ flaky tests
errorboundary.test.ts captures an exception

Flake rate in main: 29.41% (Passed 12 times, Failed 5 times)

Stack Traces | 30s run time
errorboundary.test.ts:4:1 captures an exception

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@Lms24
Copy link
Member

Lms24 commented Sep 27, 2024

hmm not sure why the e2e test is failing so consistently tbh. If you haven't already, maybe try rebasing to the latest develop

@Lms24
Copy link
Member

Lms24 commented Sep 27, 2024

hmm I have the same problem now in one of my PRs. We need to fix the solidStart e2e tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard: SvelteKit - Unknown param url
2 participants