feat(utils): Limit normalize maximum properties/elements

[timfish]

Limits number of properties/elements serialised for an object/array. An improvement over #4687 because it doesn't bail out of normalisation when the limit is reached.

This protects against huge objects being serialised if users inadvertently log huge objects.

I chose a limit of 1000 properties/elements. If this is deemed too low for a minor release, we could increase this and reduce it again for v7?

NOTE
This adds normalizeMaxBreadth to init options (documented in getsentry/sentry-docs#4844)

Ref: https://getsentry.atlassian.net/browse/WEB-711

[lobsterkatie]

I left a few language edits on the current implementation, but I have a more fundamental question.

I get why to limit the breadth of any given object/array, but why do we have to move walk inside of normalize to do it? That feels like a change which a) should happen in a separate PR if it happens, and b) makes the code harder to read and which I'd therefore try to talk you out of. 😛

[timfish]

but why do we have to move walk inside of normalize to do it?

Yep, completely unnecessary and copied from the previous PR where it made more sense!

[timfish]

I moved walk back out of normalize and the PR diff is now much more sensible 😳

Need to do a docs PR to add this option.

[lobsterkatie]

I moved walk back out of normalize and the PR diff is now much more sensible 😳

Nice. 🙂

This looks good! My only other question is naming. Given that objects have properties but arrays have elements, and this applies to both, what would you think of something more generic like normalizeMaxBreadth?

[timfish]

I've changed it to normalizeMaxBreadth

[lobsterkatie]

LGTM!

[lobsterkatie]

@timfish - Not sure if you have merge permissions, so I'm going to go ahead and pull this in. LMK if that's something you can do, and if so, I'll leave it for you in future.

[timfish]

I don't have merge permissions. Merge away!