Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(release): Add statusProvider context check for craft (#8685) #8729

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 3, 2023

Seems like the context passed isn't found which is blocking our release. Reverting for now until we know how to configure the status provider correctly (getsentry/craft#482).

#uncraft

@Lms24 Lms24 requested review from lforst and AbhiPrasad August 3, 2023 13:33
@Lms24 Lms24 enabled auto-merge (squash) August 3, 2023 13:34
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge straight to master?

@Lms24
Copy link
Member Author

Lms24 commented Aug 3, 2023

I think we have to merge to develop because craft fetches the config from the repo's default branch

@Lms24 Lms24 merged commit 99e3479 into develop Aug 3, 2023
78 checks passed
@Lms24 Lms24 deleted the lms/revert-craft-status-provider-change branch August 3, 2023 13:56
@Lms24 Lms24 mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants