-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix): move @sentry/cli to optional dependency #9740
Conversation
Hey @Mause thanks for opening a PR! What is the reason behind this move? We recently changed |
I assume installation still hard fails on platforms without pre-provided binaries? That's my reason for this change |
I opened #9741 for the Sentry CLI bump - this should have better behavior and not rely on |
What platform are you using? Perhaps we can think about extending support to it. |
On Android via Termux (https://termux.dev/en/). I'm aware this is an oddball platform, but hard failing on installing a package that isn't required isn't a great experience |
I've been overriding the resolution in yarn to a dummy empty package to work around this for now: https://github.com/Mause/github-statuses/blob/78f3fa4cef275e0bd34eb3d4a7e3a6d90a4217ca/package.json#L92 |
I agree it's poor UX that it hard fails. Hopefully the CLI bump in #9741 makes this better.
What happens if you use |
Looks like that does the trick - it's able to install, and the sentry cli binary just fail on invocation (with https://github.com/getsentry/sentry-cli/blob/c09c5991fd44b8fa4a0efff39b6953f98892e013/js/helper.js#L85), which I'm perfectly happy with |
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).Happy to add a changelog entry for this too