Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing logging in sentry_init #300

Closed
irov opened this issue Jun 16, 2020 · 1 comment · Fixed by #302
Closed

missing logging in sentry_init #300

irov opened this issue Jun 16, 2020 · 1 comment · Fixed by #302

Comments

@irov
Copy link
Contributor

irov commented Jun 16, 2020

some log in sentry_init does not show because g_options is not configured

like this

SENTRY_DEBUGF("using database path \"%" SENTRY_PATH_PRI "\"",
    options->database_path->path);
@Swatinem
Copy link
Member

🤦‍♂️ I should have paid more attention. I think it would be best to use a different global for the logger, and set it independently of g_options. I can do that tomorrow.

Swatinem added a commit that referenced this issue Jun 17, 2020
@Swatinem
fix: Start logger as early as possible
f9bf84b 
fixes #300
@Swatinem Swatinem mentioned this issue Jun 17, 2020
Merged
Swatinem added a commit that referenced this issue Jun 17, 2020
@Swatinem
fix: Start logger as early as possible (#302)
5bff34a 
fixes #300
irov pushed a commit to irov/sentry-native that referenced this issue Jun 17, 2020
@Swatinem @irov
fix: Start logger as early as possible (getsentry#302)
19320b9 
fixes getsentry#300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Start logger as early as possible getsentry/sentry-native
2 participants
@Swatinem @irov