feat: add support for SOCKS5 proxy #1063
Draft
+61
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
- Coverage 82.63% 82.52% -0.11%
==========================================
Files 53 53
Lines 7660 7670 +10
Branches 1208 1207 -1
==========================================
Hits 6330 6330
- Misses 1216 1227 +11
+ Partials 114 113 -1 |
JoshuaMoelans
changed the title
JoshuaMoelans
commented
Oct 30, 2024
JoshuaMoelans
commented
Oct 30, 2024
| @@ -215,8 +215,8 @@ sentry__curl_send_task(void *_envelope, void *_state) | |||
| curl_easy_setopt(curl, CURLOPT_HEADERDATA, (void *)&info); | |||
| curl_easy_setopt(curl, CURLOPT_HEADERFUNCTION, header_callback); | |||
|
|
|||
| if (state->http_proxy) { | |||
| curl_easy_setopt(curl, CURLOPT_PROXY, state->http_proxy); | |||
| if (state->proxy) { // TODO do we need to process the proxy here? | |||
There was a problem hiding this comment.
Curl supports socks-proxies since https://curl.se/ch/7.21.7.html ; our minimum required version is currently 7.10.7 -> This might need to be updated to ensure socks-proxies work.
There was a problem hiding this comment.
Please be aware that we have a runtime and a compile-time check for libcurl.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1030
Todo
-> test by providing socks5 url & seeing where it breaks (and for which transports it works/doesn't)
-> document if transport doesn't support it (e.g. winhttp)