Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide version information in DLL #1076

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

olback
Copy link
Contributor

@olback olback commented Nov 6, 2024

When building sentry-native as a DLL, there is currently no easy way to determine what version it is.
Windows allows you to specify version information in a resource file, the version can then be found in 'Properties' from Explorer. The version can also be queried programatically with GetFileVersionInfo{A,W}.

Here's an example (in Swedish):
bild

CMakeLists.txt Outdated Show resolved Hide resolved
sentry.rc.in Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (d241dbc) to head (79c1dc7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
+ Coverage   82.66%   82.68%   +0.02%     
==========================================
  Files          53       53              
  Lines        7717     7717              
  Branches     1213     1213              
==========================================
+ Hits         6379     6381       +2     
+ Misses       1227     1225       -2     
  Partials      111      111              

@olback olback marked this pull request as ready for review November 6, 2024 17:58
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are certainly some users who appreciate this very much.

sentry.rc.in Outdated Show resolved Hide resolved
sentry.rc.in Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants