fix: Avoid assertion when hitting shutdown_timeout #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 87.18% 87.55% +0.37%
==========================================
Files 49 49
Lines 3971 3993 +22
==========================================
+ Hits 3462 3496 +34
+ Misses 509 497 -12
Continue to review full report at Codecov.
|
This was referenced Jun 29, 2020
flub
approved these changes
Jul 3, 2020
|
Notes from an offline discussion: When the crash happens close to startup, it is more likely that it interrupts an ongoing upload. In this case, it would be better to avoid dropping it. If we refcount the envelopes in the transport queue, we could have multiple threads read and clean the queue concurrently. |
dump send queue on unclean shutdown
jan-auer
reviewed
Jul 7, 2020
Swatinem
force-pushed
the
fix/cancel-threads
branch
from
2f50fa6
to
0073054
Compare
jan-auer
reviewed
Jul 8, 2020
jan-auer
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the task locking and background worker shutdown logic.
Tasks are now refcounted so they can be executed concurrently while another thread removes them from the queue. In case the background worker can’t be cleanly shut down (due to slow network), the task queue is being dumped, but the background worker itself is not freed from the main thread, to avoid potential use-after-free bugs.
Also, the background worker itself is refcounted and owns its state.
The transport state is now owned by the background worker, and passed explicitly to the task send function. The task state itself was removed in favor of providing the envelope directly.