Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Litestar #2413

Closed
sentrivana opened this issue Oct 4, 2023 · 7 comments · Fixed by #3358
Closed

Support Litestar #2413

sentrivana opened this issue Oct 4, 2023 · 7 comments · Fixed by #3358
Labels
Enhancement New feature or request New Integration Integrating with a new framework or library Triaged Has been looked at recently during old issue triage

Comments

@sentrivana
Copy link
Contributor

Problem Statement

Starlite was renamed to Litestar. Since we already have a Starlite integration, adding support for Litestar should in the ideal case just be a matter of checking the changelog for the new major and creating a new integration based on the existing one.

Solution Brainstorm

Write the new integration.

@sentrivana sentrivana added Enhancement New feature or request New Integration Integrating with a new framework or library labels Oct 4, 2023
@JacobCoffee
Copy link

Hi! Let us know if there is any extra details that may be helpful in this. We may have some resources we can throw at this to tackle the PR but I am doubtful as it stands right now (at least for a little while!).. but we would love to see native support for this as well :)

@sentrivana
Copy link
Contributor Author

Hey @JacobCoffee, thanks for the support! Same goes the other way -- if anyone feels like tackling this, we're happy to provide support. The case of Litestar as an integration is special since we've already integrated with Starlite, so whoever takes this on doesn't have to start from square one but rather build on what we already have, which should make it easier.

Folks reading this, please give the original issue a 👍🏻 if this is something you want, it helps us prioritize this internally as well.

@guacs
Copy link

guacs commented Dec 12, 2023

@sentrivana I'd like to take a crack at this. I looked at the existing integration with Starlite, and like you said it shouldn't be too difficult to use that as a base for the Litestar integration.

@sentrivana
Copy link
Contributor Author

Thank you @guacs! Exactly, I'd start by just copying the Starlite integration into a new file and then taking it from there. Additionally there is a few housekeeping places that will need changing throughout the SDK, like adding Litestar to tox.ini, to our GitHub workflow generator script, adding some span OP constants, etc. -- for updating those you can just grep for starlite and add the same for litestar.

@jeanlst
Copy link

jeanlst commented Jan 15, 2024

@sentrivana @guacs any news on this?

@sentrivana
Copy link
Contributor Author

No news yet @jeanlst -- same situation as before, we probably won't get around to doing this soon, but happy to provide support if anyone wants to give it a try.

@guacs
Copy link

guacs commented Jan 16, 2024

@sentrivana @guacs any news on this?

Sorry I've just gotten quite busy for a while! Unfortunately, I think it may be a few weeks before I'll get a chance to work on this :/

@sentrivana sentrivana added the Triaged Has been looked at recently during old issue triage label Jul 1, 2024
sentrivana added a commit that referenced this issue Aug 12, 2024
Adds support for Litestar through a new LitestarIntegration based on porting the existing StarliteIntegration.
Starlite was renamed Litestar as part of its move to version 2.0.

Closes #2413

---------

Co-authored-by: Ivana Kellyer <[email protected]>
Co-authored-by: Daniel Szoke <[email protected]>
Co-authored-by: Anton Pirker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request New Integration Integrating with a new framework or library Triaged Has been looked at recently during old issue triage
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants