Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exported types are not importable by mypy #2910

Closed
evanpurkhiser opened this issue Mar 26, 2024 · 0 comments · Fixed by #2913
Closed

Exported types are not importable by mypy #2910

evanpurkhiser opened this issue Mar 26, 2024 · 0 comments · Fixed by #2913
Assignees
@szokeasaurusrex

Comments

@evanpurkhiser
Copy link
Member

How do you use Sentry?

Sentry Saas (sentry.io)

Version

1.43.0

Steps to Reproduce

https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/types.py

I am unable to import this type, CI is unhappy.

Related-ish to #2909

Expected Result

Importable type

Actual Result

https://github.com/getsentry/sentry/actions/runs/8440333511/job/23117012964?pr=67623
@szokeasaurusrex szokeasaurusrex mentioned this issue Mar 27, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Mar 27, 2024
@szokeasaurusrex @antonpirker
Explicit reexport of types (#2866) (#2913)
790ee6a 
Explicitly reexport types to make strict mypy setups happy. This backports #2866 to 1.x.

Fixes GH-2910

Co-authored-by: Anton Pirker <[email protected]>
@szokeasaurusrex szokeasaurusrex self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: Explicit reexport of types (backport to 1.x) getsentry/sentry-python
2 participants
@evanpurkhiser @szokeasaurusrex