Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using sentry_sdk.configure_scope in SDK #3344

Closed
szokeasaurusrex opened this issue Jul 25, 2024 · 0 comments · Fixed by #3350, #3349 or #3348
Closed

Stop using sentry_sdk.configure_scope in SDK #3344

szokeasaurusrex opened this issue Jul 25, 2024 · 0 comments · Fixed by #3350, #3349 or #3348
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

Looks like we only use configure_scope in tests; all of these usages should be removed, except for those tests which exist primarily to test that configure_scope continues to work.
@szokeasaurusrex szokeasaurusrex self-assigned this Jul 25, 2024
szokeasaurusrex added a commit that referenced this issue Jul 25, 2024
@szokeasaurusrex
test(celery): Stop using configure_scope
ab408f2 
Use `Scope.get_isolation_scope` instead.

Ref #3344
@szokeasaurusrex szokeasaurusrex mentioned this issue Jul 25, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Jul 25, 2024
@szokeasaurusrex
test(basics): Stop using configure_scope
682f07a 
Use `Scope.get_isolation_scope` instead.

Ref #3344
@szokeasaurusrex szokeasaurusrex mentioned this issue Jul 25, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Jul 25, 2024
@szokeasaurusrex
test(client): Avoid configure_scope
4aa4c01 
Replace the only `configure_scope` usage in `test_client.py`, which
can be replaced without defeating the test's purpose, with
`Scope.get_isolation_scope`. The other `configure_scope` calls are
made either from a test which specifically tests `configure_scope`
or from a test which is always skipped.

Closes: #3344
@szokeasaurusrex szokeasaurusrex mentioned this issue Jul 25, 2024
Merged
This was linked to pull requests Jul 26, 2024
test(client): Avoid configure_scope #3350
Merged
test(basics): Stop using configure_scope #3349
Merged
test(celery): Stop using configure_scope #3348
Merged
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
test(celery): Stop using configure_scope
afca706 
Use `Scope.get_isolation_scope` instead.

Ref #3344
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
test(celery): Stop using configure_scope (#3348)
cc0ee38 
Use `Scope.get_isolation_scope` instead.

Ref #3344
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
test(basics): Stop using configure_scope (#3349)
132a9c5 
Use `Scope.get_isolation_scope` instead.

Ref #3344
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
test(client): Avoid configure_scope (#3350)
1d17d57 
Replace the only `configure_scope` usage in `test_client.py`, which
can be replaced without defeating the test's purpose, with
`Scope.get_isolation_scope`. The other `configure_scope` calls are
made either from a test which specifically tests `configure_scope`
or from a test which is always skipped.

Closes: #3344
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@szokeasaurusrex @arjenzorgdoc
test(celery): Stop using configure_scope (getsentry#3348)
658c2fe 
Use `Scope.get_isolation_scope` instead.

Ref getsentry#3344
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@szokeasaurusrex @arjenzorgdoc
test(basics): Stop using configure_scope (getsentry#3349)
d40bc9f 
Use `Scope.get_isolation_scope` instead.

Ref getsentry#3344
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@szokeasaurusrex @arjenzorgdoc
test(client): Avoid configure_scope (getsentry#3350)
ab80f4e 
Replace the only `configure_scope` usage in `test_client.py`, which
can be replaced without defeating the test's purpose, with
`Scope.get_isolation_scope`. The other `configure_scope` calls are
made either from a test which specifically tests `configure_scope`
or from a test which is always skipped.

Closes: getsentry#3344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@szokeasaurusrex