Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully deprecate hub-based logic in sessions.py #3417

Closed
szokeasaurusrex opened this issue Aug 8, 2024 · 0 comments · Fixed by #3419
Closed

Fully deprecate hub-based logic in sessions.py #3417

szokeasaurusrex opened this issue Aug 8, 2024 · 0 comments · Fixed by #3419
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

No description provided.

@szokeasaurusrex szokeasaurusrex self-assigned this Aug 8, 2024
szokeasaurusrex added a commit that referenced this issue Aug 8, 2024
@szokeasaurusrex
ref(sessions): Deprecate hub-based sessions.py logic
ccf35e4 
Make several changes to prepare for fully removing Hubs in the next major:
  - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session`
  - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function
  - To limit public API surface, deprecate `is_auto_session_tracking_enabled` and `is_auto_session_tracking_enabled_scope` and replace them with a Scope-based private function called `_is_auto_session_tracking_enabled`
  - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests.
  - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested.

Fixes #3417
@szokeasaurusrex szokeasaurusrex mentioned this issue Aug 8, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Aug 8, 2024
@szokeasaurusrex
ref(sessions): Deprecate hub-based sessions.py logic
f946729 
Make several changes to prepare for fully removing Hubs in the next major:
  - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session`
  - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function
  - To limit public API surface, deprecate `is_auto_session_tracking_enabled` and `is_auto_session_tracking_enabled_scope` and replace them with a Scope-based private function called `_is_auto_session_tracking_enabled`
  - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests.
  - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested.

Fixes #3417
szokeasaurusrex added a commit that referenced this issue Aug 8, 2024
@szokeasaurusrex
ref(sessions): Deprecate hub-based sessions.py logic
c0e5fad 
Make several changes to prepare for fully removing Hubs in the next major:
  - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session`
  - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function
  - To limit public API surface, deprecate `is_auto_session_tracking_enabled` and `is_auto_session_tracking_enabled_scope` and replace them with a Scope-based private function called `_is_auto_session_tracking_enabled`
  - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests.
  - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested.

Fixes #3417
szokeasaurusrex added a commit that referenced this issue Aug 9, 2024
@szokeasaurusrex
ref(sessions): Deprecate hub-based sessions.py logic
403e131 
Make several changes to prepare for fully removing Hubs in the next major:
  - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session`
  - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function
  - To limit public API surface, deprecate `is_auto_session_tracking_enabled` and `is_auto_session_tracking_enabled_scope` and replace them with a Scope-based private function called `_is_auto_session_tracking_enabled`
  - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests.
  - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested.

Fixes #3417
szokeasaurusrex added a commit that referenced this issue Aug 9, 2024
@szokeasaurusrex
ref(sessions): Deprecate is_auto_session_tracking_enabled
dbcd959 
Deprecate the Hub-based `is_auto_session_tracking_enabled` and the Scope-based `is_auto_session_tracking_enabled_scope`, and replace them with a new Scope-based private-API equivalent.

Partially implements #3417
@szokeasaurusrex szokeasaurusrex mentioned this issue Aug 9, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Aug 9, 2024
@szokeasaurusrex
ref(sessions): Deprecate is_auto_session_tracking_enabled (#3428)
6a4e729 
Deprecate the Hub-based `is_auto_session_tracking_enabled` and the Scope-based `is_auto_session_tracking_enabled_scope`, and replace them with a new Scope-based private-API equivalent.

Partially implements #3417
szokeasaurusrex added a commit that referenced this issue Aug 9, 2024
@szokeasaurusrex
ref(sessions): Deprecate hub-based sessions.py logic
6111f9c 
Make several changes to prepare for fully removing Hubs in the next major:
  - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session`
  - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function
  - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests.
  - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested.

Fixes #3417
szokeasaurusrex added a commit that referenced this issue Aug 9, 2024
@szokeasaurusrex
ref(sessions): Deprecate is_auto_session_tracking_enabled (#3428)
f4e1455 
Deprecate the Hub-based `is_auto_session_tracking_enabled` and the Scope-based `is_auto_session_tracking_enabled_scope`, and replace them with a new Scope-based private-API equivalent.

Partially implements #3417
szokeasaurusrex added a commit that referenced this issue Aug 9, 2024
@szokeasaurusrex
ref(sessions): Deprecate hub-based sessions.py logic
c76e1d7 
Make several changes to prepare for fully removing Hubs in the next major:
  - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session`
  - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function
  - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests.
  - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested.

Fixes #3417
szokeasaurusrex added a commit that referenced this issue Aug 9, 2024
@szokeasaurusrex
ref(sessions): Deprecate hub-based sessions.py logic (#3419)
275c63e 
Make several changes to prepare for fully removing Hubs in the next major:
  - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session`
  - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function
  - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests.
  - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested.

Fixes #3417
sentrivana pushed a commit that referenced this issue Aug 12, 2024
@szokeasaurusrex @sentrivana
ref(sessions): Deprecate is_auto_session_tracking_enabled (#3428)
2ca2e28 
Deprecate the Hub-based `is_auto_session_tracking_enabled` and the Scope-based `is_auto_session_tracking_enabled_scope`, and replace them with a new Scope-based private-API equivalent.

Partially implements #3417
sentrivana pushed a commit that referenced this issue Aug 12, 2024
@szokeasaurusrex @sentrivana
ref(sessions): Deprecate hub-based sessions.py logic (#3419)
f9573a6 
Make several changes to prepare for fully removing Hubs in the next major:
  - Deprecate the Hub-based `auto_session_tracking` function, replacing it with a new Scope-based function called `track_session`
  - Deprecate the scope-based `auto_session_tracking_scope` in favor of the new `track_session` function
  - Change usages of `auto_session_tracking_scope` to `track_sessions`. There are no usages of `auto_session_tracking` outside of tests.
  - Run all tests that were previously run against `auto_session_tracking` also against the new `track_session`. Previously, `auto_session_tracking_scope` was completely untested.

Fixes #3417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(sessions): Deprecate hub-based sessions.py logic getsentry/sentry-python
1 participant
@szokeasaurusrex