Add `before_send_transaction` #1840

antonpirker · 2023-01-16T11:35:56Z

Callback function that is called for all transactions (in opposite to before_send which is only called for issue events)

Fixes #1738

antonpirker · 2023-01-17T12:33:02Z

tests/test_basics.py

sentry_sdk/client.py

…our that is already tested somewhere else.

Co-authored-by: Neel Shah <[email protected]>

codecov.yml

…or mypy (and therefore not relevant at runtime)

Added before_send_transaction

8b0b930

antonpirker changed the title ~~Add before_send_transaction~~ Add before_send_transaction Jan 16, 2023

Test for before_send_transaction

fe64837

antonpirker marked this pull request as ready for review January 17, 2023 12:33

antonpirker requested a review from sl0thentr0py January 17, 2023 12:33

sl0thentr0py requested changes Jan 17, 2023

View reviewed changes

tests/test_basics.py Show resolved Hide resolved

sentry_sdk/client.py Outdated Show resolved Hide resolved

antonpirker and others added 5 commits January 18, 2023 11:06

Merge branch 'master' into antonpirker/add-before-send-transaction

598c482

Removed useless checks, because they check just the normal sdk behavi…

3c0aa59

…our that is already tested somewhere else.

Update sentry_sdk/client.py

a51b337

Co-authored-by: Neel Shah <[email protected]>

Codecov should ignore tests directory

763994f

More test coverage

b99d39f

antonpirker commented Jan 18, 2023

View reviewed changes

codecov.yml Show resolved Hide resolved

sl0thentr0py approved these changes Jan 18, 2023

View reviewed changes

Codecov should ignore _types.py because it is only type definitions f…

578293d

…or mypy (and therefore not relevant at runtime)

antonpirker merged commit 3f38f79 into master Jan 18, 2023

antonpirker deleted the antonpirker/add-before-send-transaction branch January 18, 2023 14:29

Provide feedback