feat: Add db.system indicators to redis, sqlalchemy, and django
#2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
commented
Apr 25, 2023
| @@ -578,7 +580,10 @@ def execute(self, sql, params=None): | |||
|
|
|||
| with record_sql_queries( | |||
| hub, self.cursor, sql, params, paramstyle="format", executemany=False | |||
| ): | |||
| ) as span: | |||
| vendor = connection.vendor | |||
There was a problem hiding this comment.
I realized this strategy doesn't work if you have multiple connections open, but not sure how common that is.
There was a problem hiding this comment.
In Django it is common to have one connection to a read only replica of the database and one you use to change the data, so probably on bigger installations quite common.
Merged
|
Splitting this up in favour of 4 PRs:
|
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref getsentry/team-webplatform-meta#60
dependent on getsentry/develop#917
Add this information to span data field as db.system, matching OpenTelemetry's well known conventions.
For example, db.system of postgresql would indicate that it's a postgres database.