Fix 2.7 tests #2145
Fix 2.7 tests #2145
Conversation
sentrivana
force-pushed
the
ivana/fix-2.7-tests
branch
from
0801e6c
to
cf89324
Compare
sentrivana
force-pushed
the
ivana/fix-2.7-tests
branch
from
cf89324
to
c279ef1
Compare
|
Hey @Zylphrex, could you please take a look at the failing profiler tests for py 2.7 (here and here)? TL;DR why this is coming up now: the CI wasn't actually executing the I'll take care of the rest but don't know much about the profiler. |
You can disable the profiler tests for 2.7 as it's only meant to work with >3. |
Ok, will do, thanks! |
| assert event["_meta"]["extra"]["auth"] == {"": {"rem": [["!config", "s"]]}} | ||
| assert event["_meta"]["breadcrumbs"] == { | ||
| "values": {"0": {"data": {"password": {"": {"rem": [["!config", "s"]]}}}}} |
There was a problem hiding this comment.
Changed this because in py2.7 there's an additional 'sys.argv': {'': {'len': 11}}}} in event["_meta"]["extra"], I'm guessing from here. Unsure why this only happens on 2.7 but it doesn't seem to be something that needs to be fixed.
| @@ -124,8 +122,8 @@ def test_span_data_scrubbing(sentry_init, capture_events): | |||
|
|
|||
| (event,) = events | |||
| assert event["spans"][0]["data"] == {"password": "[Filtered]", "datafoo": "databar"} | |||
| assert event["_meta"] == { | |||
| "spans": {"0": {"data": {"password": {"": {"rem": [["!config", "s"]]}}}}} | |||
| assert event["_meta"]["spans"] == { | |||
The Python 2.7 common test suite fails to execute properly, leading the CI to think the tests passed and unfortunately also masking multiple actual test failures.
Fixes #2139