Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(transport): Stop using Hub in HttpTransport #3247

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

szokeasaurusrex
Copy link
Member

Also, add deprecation warnings for HttpTransport.hub_cls.

Fixes #3232

Also, add deprecation warnings for `HttpTransport.hub_cls`.

Fixes #3232
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/no-hub-transport branch from c05afaa to 05d2087 Compare July 4, 2024 10:51
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's drop this in 3.0.

@szokeasaurusrex
Copy link
Member Author

Nice, let's drop this in 3.0.

@sentrivana You mean we should drop the self.hub_cls compatibility code with 3.0, correct? Can we still merge this PR now and release in a 2.x minor?

@sentrivana
Copy link
Contributor

@sentrivana You mean we should drop the self.hub_cls compatibility code with 3.0, correct? Can we still merge this PR now and release in a 2.x minor?

Yes, we can merge and release! Sorry for the confusion.

@szokeasaurusrex szokeasaurusrex merged commit 31efa62 into master Jul 4, 2024
122 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/no-hub-transport branch July 4, 2024 11:04
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Also, add deprecation warnings for `HttpTransport.hub_cls`.

Fixes getsentry#3232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop Using Hub in HttpTransport
2 participants